Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rely on warg-credentials for keyring management #251

Merged
merged 3 commits into from
Mar 8, 2024
Merged

Conversation

macovedj
Copy link
Collaborator

@macovedj macovedj commented Mar 5, 2024

leverage warg-credentials for keyring management

@macovedj macovedj force-pushed the warg-credentials branch 5 times, most recently from 13d09ec to 5f65cd6 Compare March 6, 2024 15:40
Copy link
Member

@peterhuene peterhuene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for making these changes!

Just some minor stuff to correct.

Cargo.toml Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
crates/core/Cargo.toml Outdated Show resolved Hide resolved
crates/wit/Cargo.toml Outdated Show resolved Hide resolved
src/commands/key.rs Outdated Show resolved Hide resolved
@peterhuene peterhuene merged commit 6ed49ca into main Mar 8, 2024
6 checks passed
@peterhuene peterhuene deleted the warg-credentials branch March 8, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants