Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to use a Provider abstraction #787

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Conversation

jeffcharles
Copy link
Collaborator

Description of the change

I'm adding a Provider abstraction which provides methods that need to be polymorphic over a provider.

Why am I making this change?

As part of #768 I'll need to thread a plugin module through a bunch of the code. This refactoring front-loads some of those changes.

Checklist

  • I've updated the relevant CHANGELOG files if necessary. Changes to javy-cli and javy-core do not require updating CHANGELOG files.
  • I've updated the relevant crate versions if necessary. Versioning policy for library crates
  • I've updated documentation including crate documentation if necessary.

Copy link
Member

@saulecabrera saulecabrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me!

@jeffcharles jeffcharles merged commit 1ffa0a7 into main Oct 21, 2024
7 checks passed
@jeffcharles jeffcharles deleted the jc.refactor-providers branch October 21, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants