Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor to set a default provider #788

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Refactor to set a default provider #788

merged 1 commit into from
Oct 22, 2024
+10 −12

Conversation

jeffcharles
Copy link
Collaborator

Description of the change

Makes Provider implement the Default trait and removes some superfluous code as a result.

Why am I making this change?

A refactoring to reduce the scope of the changes introduced in unifying static and dynamic codegen.

Checklist

  • I've updated the relevant CHANGELOG files if necessary. Changes to javy-cli and javy-core do not require updating CHANGELOG files.
  • I've updated the relevant crate versions if necessary. Versioning policy for library crates
  • I've updated documentation including crate documentation if necessary.

@jeffcharles jeffcharles merged commit b95c4fc into main Oct 22, 2024
7 checks passed
@jeffcharles jeffcharles deleted the jc.refactor-to-default-provider branch October 22, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saulecabrera saulecabrera saulecabrera approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeffcharles @saulecabrera