fix: multi-state poll state architecture #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guybedford
changed the title
guybedford
changed the title
guybedford
changed the title
guybedford
changed the title
guybedford
force-pushed
the
multi-poll
branch
from
c31b5be
to
bf2851e
Compare
This was referenced Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously JCO's WASI implementation treated polls as single-resolvable, when in fact they support transitioning back and fourth from resolved to unresolved for multi state support.
This updates the core poll implementation to be conformant with the expected behaviour and updates to the latest Wasmtime tests. Wasmtime tests have since been added to catch this behaviour.