feat: allow custom weval bin #522
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit enables specifying a custom `weval` binary to use when performing AOT. Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
guybedford
reviewed
Nov 8, 2024
| @@ -34,6 +34,7 @@ program.command('componentize') | |||
| .requiredOption('-w, --wit <path>', 'WIT path to build with') | |||
| .option('-n, --world-name <name>', 'WIT world to build') | |||
| .option('--aot', 'Enable Weval AOT compilation of JS') | |||
| .option('--weval-bin <path>', 'Specify a custom weval binary to use') | |||
There was a problem hiding this comment.
I would have expected we'd need to set this somewhere in this PR to use it?
There was a problem hiding this comment.
Yes -- this PR actually isn't quite ready yet -- I need to make sure that installing weval with https://github.com/jaxxstorm/action-install-gh-release actually works. Will move this to draft while I work on the CI bits.
The place this has to go is in the CLI test where we call componentize -- just haven't added it yet!
Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
vados-cosmonic
force-pushed
the
feat=allow-custom-weval-bin
branch
from
ca21b33
to
8172e0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit enables using a custom
wevalbinary fromjco(see also bytecodealliance/ComponentizeJS#156) -- the idea is to hopefully download the weval binary separately from the actual test (i.e. wherejco componentizegets run), and be able to use it w/ jco specifically via arg & env var from CI.Example failure