server: Add /debug/package/<id> endpoint #174
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lann
force-pushed
the
package-debug-endpoint
branch
from
06e14bd
to
e30bcf7
Compare
peterhuene
approved these changes
Jul 25, 2023
crates/server/src/api/debug/mod.rs
Outdated
| @@ -18,18 +35,144 @@ impl Config { | |||
| pub fn into_router(self) -> Router { | |||
| Router::new() | |||
| .route("/packages", get(list_package_names)) | |||
| .route("/package/:name", get(get_package_info)) | |||
There was a problem hiding this comment.
Nit: while name is pretty synonymous with package id, perhaps this just for clarity?
Suggested change
| .route("/package/:name", get(get_package_info)) | |
| .route("/package/:package_id", get(get_package_info)) |
There was a problem hiding this comment.
Oops, I even changed it in the function signature...
lann
force-pushed
the
package-debug-endpoint
branch
from
e30bcf7
to
545c67c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This dumps a package's log and derived (validated) state as a debugging tool.