-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added registry index for fetched records and updated proof endpoints to use the log length and registry index #187
Conversation
I need to investigate why it is failing on the inclusion proof on the Postgres test. Trying to reproduce. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good to me, pending CI failure.
…e consistent throughout the proof bundle creation
Should be good to go now. The Postgres test failure was tricky to track down, since I thought it was failing on the inclusion of the log. It was the map inclusion proof that was failing intermittently. When constructing the proof bundle, the leafs need to be added in the exact same order as the client provided the log leafs. It was easier to enforce the ordering in Rust than mess with the |
Also, updated the The updated rendered OpenAPI spec. This PR should be compatible with the existing Postgres DB data and shouldn't require starting fresh with the Dogfood Registry deployment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you give this a pass through cargo clippy
? If you use vscode you can make it the default linter with "rust-analyzer.check.command": "clippy"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure I understand the new RegistryIndex
param threaded through CoreService
but otherwise lgtm.
The registry index for a published record is going to be different than the
VecLog
'sNode(usize)
value that is required for the log inclusion proof. For now, keeping the existing pattern of using aHashMap
(could be aVec
if added back in the same order) to lookup the value in memory.To make it easier to adjust the size of the integer for the
log_length
andregistry_index
, I added a type aliasRegistryIndex
.As always, suggestions appreciated. This was more of a change than I expected.