Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bitflags dependency to 2.2.1. #651

Closed
wants to merge 2 commits into from

Conversation

qwandor
Copy link

@qwandor qwandor commented May 3, 2023

This requires some minor code changes, mostly around deriving traits explicitly as they are no longer derived by default by the bitflags macro.

This requires some minor code changes, mostly around deriving traits
explicitly as they are no longer derived by default by the bitflags
macro.
@qwandor
Copy link
Author

qwandor commented May 3, 2023

This is needed to unblock clap-rs/clap#4861, which in turn is needed to avoid having two different version of bitflags in Android.

@qwandor
Copy link
Author

qwandor commented May 3, 2023

It looks like this will mean updating the MSRV to 1.56, to allow the 2021 edition.

@sunfishcode
Copy link
Member

Rustix's current MSRV policy is to support Debian stable, and a new Debian stable release is expected in about a month from now. So one option here is to wait for that before updating here.

Is there a need to move more quickly here?

@qwandor
Copy link
Author

qwandor commented May 3, 2023

Thanks for the quick reply! An earlier release would be nice, but we can live with that.

@sunfishcode sunfishcode added the semver bump Issues that will require a semver-incompatible fix label May 4, 2023
@oxalica
Copy link
Contributor

oxalica commented Jun 10, 2023

The Debian stable release is out. Could we make this forward to 1.63?
https://packages.debian.org/bookworm/rustc

@oxalica
Copy link
Contributor

oxalica commented Jun 11, 2023

The Debian stable release is out. Could we make this forward to 1.63? https://packages.debian.org/bookworm/rustc

Oh, there's already a separated one #687

@sunfishcode
Copy link
Member

Yes, I apologize, I forget about this PR and ended up making a separate patch to update to bitflags 2. That patch is now merged, so we can now close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver bump Issues that will require a semver-incompatible fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants