Use u32 to represent most flags and enum types.
#701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunfishcode
force-pushed
the
sunfishcode/flags
branch
2 times, most recently
from
b0b095b
to
3711916
Compare
This makes the types consistent between the linux_raw and libc backends. And, using unsigned types for flags is more idiomatic for Rust. To avoid the risk of `as` silently casting away bits, introduce new `bitcast` and `bitflags_bits` macros which convert their argument to the needed integer type while only changing its signedness interpretation.
sunfishcode
force-pushed
the
sunfishcode/flags
branch
from
3711916
to
2636d07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the types consistent between the linux_raw and libc backends. And, using unsigned types for flags is more idiomatic for Rust.
To avoid the risk of
assilently casting away bits, introduce newbitcastandbitflags_bitsmacros which convert their argument to the needed integer type while only changing its signedness interpretation.These macros use
transmuteinternally, to ensure that the source and destination are the same size, so they also include code to prevent them from being used on non-integer types.