Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass null as empty slices to getxattr on macOS #970

Merged
merged 2 commits into from
Dec 18, 2023
Merged

Pass null as empty slices to getxattr on macOS #970

merged 2 commits into from
Dec 18, 2023

Conversation

notgull
Copy link
Contributor

@notgull notgull commented Dec 9, 2023

Closes #957

@notgull
Pass null as empty slices to getxattr on macOS
9931730 
Closes bytecodealliance#957

Signed-off-by: John Nunley <dev@notgull.net>
@notgull
Fix comment
f8cf24e 
Signed-off-by: John Nunley <dev@notgull.net>
@sunfishcode sunfishcode merged commit 10361e7 into bytecodealliance:main Dec 18, 2023
44 checks passed
@sunfishcode
Copy link
Member

Thanks!

@sunfishcode
Copy link
Member

This is released in rustix 0.38.29.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunfishcode sunfishcode sunfishcode left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Passing an empty slice to lgetxattr on macOS returns ERANGE no matter what
2 participants
@notgull @sunfishcode