-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add export!
macros
#77
Conversation
export!
macros
This adds two macros that wrap wit_bindgen::generate! with appropriate path, world, exports, and with options: - `wasi::cli::run::export!` for `wasi:cli/run` - `wasi::http::incoming_handler::export!` for `wasi:http/incoming-handler`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks great to me, thanks for both the suggestion and the implementation!
Oh I realize now though that this isn't tested on CI. Can you add a CI check to ensure that the crate builds with this feature enabled? For other nice-to-haves, feel free to defer these to either a future PR or a future contributor:
Again though these points aren't critical, only the CI bit I think is critical to have before landing. |
Added
Added "Export Macros" section to root docs.
Added "Compatibility with |
Thanks again for all this! |
Also update bindings.rs with wit-bindgen 0.19.2.
Closes #76