fix(warg): Removes call to cache for versions #72
Conversation
|
Note that I also pushed the fix for non-https urls here from #68 so it was decoupled from that |
| let url = warg_meta.url.unwrap_or_else(|| { | ||
| // If we just pass registry plain, warg will assume it is https. This is a workaround to | ||
| // assume that a local registry is http. | ||
| if registry.host() == "localhost" || registry.host() == "127.0.0.1" { |
There was a problem hiding this comment.
0.0.0.0 is a weird one because it means all interfaces for some things and I think it is rejected (maybe?) on Windows
|
Could you point me to where in |
|
Calling |
|
@calvinrp So it looks like the update method updates all packages rather than just a specific one being fetched. That feels like it could be possibly expensive operation to run every time someone wants to fetch a package. Is that still the best option? I feel like fetching only for a specific package every time is a bit more predictable. I just don't know if it is going to cause heavy load on a server to list all packages to a client and then update the checkpoints (even if those checkpoints are empty data updates) |
|
@thomastaylor312 Sorry, I'm just trying to understand why the caching is problem. On how this being called. |
The implementation for listing versions was pulling from the cache. This caused it to miss updates to versions when being used in cargo-component. I discovered this while working on cargo-component and it was blocking tests from working Signed-off-by: Taylor Thomas <taylor@cosmonic.com>
Signed-off-by: Taylor Thomas <taylor@cosmonic.com>
thomastaylor312
force-pushed
the
fix/cached_versions
branch
from
03495bf
to
637284b
Compare
|
@calvinrp and I synced offline. For now we are going to call |
The implementation for listing versions was pulling from the cache. This caused it to miss updates to versions when being used in cargo-component.
I discovered this while working on cargo-component and it was blocking tests from working