feat(wkg-core): Adds new wkg-core crate with lockfile support #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes support for an optional config and tests for locking Signed-off-by: Taylor Thomas <taylor@cosmonic.com>
thomastaylor312
force-pushed
the
feat/wit_command
branch
from
f8bce32
to
c372d0a
Compare
|
Heads up that the test failure is happening because macos runners don't have docker installed by default. I'll figure that out shortly |
thomastaylor312
force-pushed
the
feat/wit_command
branch
from
c372d0a
to
20b3895
Compare
lann
reviewed
Sep 25, 2024
This adds a new `wit` subcommand to `wkg` that supports building wit packages and fetching/populating a deps directory. I'm sure there is much more we can do here and some obtuse edge cases that aren't supported, but I did test fetching dependencies for various worlds that used wasi:http and wasi:cli. In a follow up PR, I'll add some more integration tests Signed-off-by: Taylor Thomas <taylor@cosmonic.com>
thomastaylor312
force-pushed
the
feat/wit_command
branch
from
20b3895
to
f6d712c
Compare
|
Heads up that I added a commit with integration tests. Update isn't tested yet because we need to be pointing at wasi.dev so we can try an update from 0.2.1, but also that doesn't do much yet (it is essentially the same as fetch but forces a new lock file (for example if you changed registries) |
thomastaylor312
force-pushed
the
feat/wit_command
branch
from
5d6100f
to
a7be547
Compare
thomastaylor312
force-pushed
the
feat/wit_command
branch
3 times, most recently
from
5a477aa
to
afad3f0
Compare
Signed-off-by: Taylor Thomas <taylor@cosmonic.com>
thomastaylor312
force-pushed
the
feat/wit_command
branch
from
afad3f0
to
9db8f08
Compare
calvinrp
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new
witsubcommand towkgthat supports building wit packages and fetching/populating a deps directory. I'm sure there is much more we can do here and some obtuse edge cases that aren't supported, butI did test fetching dependencies for various worlds that used wasi:http and wasi:cli so the basics are functional! In a follow up PR, I'll add some more integration tests