fix(ci): Create release before uploading

.github/workflows/publish-binaries.yml

@@ -62,11 +62,25 @@ jobs:
         shell: bash
         run: gh auth login --with-token < <(echo ${{ secrets.GITHUB_TOKEN }})
       - run: gh release upload -R bytecodealliance/wasm-pkg-tools --clobber dev target/${{ matrix.rust-target }}/release/wkg-${{ matrix.rust-target }}
-
+
+  create_tagged_release:
+    if: github.event_name == 'push' && startsWith(github.ref, 'refs/tags/v') && github.repository == 'bytecodealliance/wasm-pkg-tools'
+    name: Create tagged release
+    runs-on: ubuntu-latest
+    permissions:
+      contents: write
+    steps:
+      - name: Login GH CLI
+        shell: bash
+        run: gh auth login --with-token < <(echo ${{ secrets.GITHUB_TOKEN }})
+      - run: gh release create -R bytecodealliance/wasm-pkg-tools ${{ github.ref_name }}
+
   publish_tagged_release:
     if: github.event_name == 'push' && startsWith(github.ref, 'refs/tags/v') && github.repository == 'bytecodealliance/wasm-pkg-tools'
     name: Publish to tagged release
     runs-on: ${{ matrix.os }}
+    needs:
+      - create_tagged_release
     strategy:
       matrix:
         include:
@@ -114,12 +128,16 @@ jobs:
         run: rustup update stable --no-self-update && rustup default stable
       - name: Publish wasm-pkg-common
         working-directory: ./crates/wasm-pkg-common
+        # TODO: temporary hack because we can't noop publish. Will remove after release
+        continue-on-error: true
         run: cargo publish
       - name: Publish wasm-pkg-client
         working-directory: ./crates/wasm-pkg-client
+        # TODO: temporary hack because we can't noop publish. Will remove after release
+        continue-on-error: true
         run: cargo publish
-      - name: Publish wkg-core
-        working-directory: ./crates/wkg-core
+      - name: Publish wasm-pkg-core
+        working-directory: ./crates/wasm-pkg-core
         run: cargo publish
       - name: Publish wkg
         working-directory: ./crates/wkg

Cargo.toml

@@ -40,4 +40,4 @@ wasm-pkg-client = { version = "0.6.0", path = "crates/wasm-pkg-client" }
 wasm-metadata = "0.217"
 wit-component = "0.217"
 wit-parser = "0.217"
-wkg-core = { version = "0.6.0", path = "crates/wkg-core" }
+wasm-pkg-core = { version = "0.6.0", path = "crates/wasm-pkg-core" }

crates/wkg-core/Cargo.toml → crates/wasm-pkg-core/Cargo.toml

@@ -1,7 +1,7 @@
 [package]
-name = "wkg-core"
+name = "wasm-pkg-core"
 description = "Wasm Package Tools core libraries for wkg"
-repository = "https://github.com/bytecodealliance/wasm-pkg-tools/tree/main/crates/wkg-core"
+repository = "https://github.com/bytecodealliance/wasm-pkg-tools/tree/main/crates/wasm-pkg-core"
 edition.workspace = true
 version.workspace = true
 authors.workspace = true

crates/wkg-core/tests/build.rs → crates/wasm-pkg-core/tests/build.rs

@@ -1,5 +1,5 @@
+use wasm_pkg_core::{config::Config as WkgConfig, lock::LockFile};
 use wit_component::DecodedWasm;
-use wkg_core::{config::Config as WkgConfig, lock::LockFile};
 
 mod common;
 
@@ -12,7 +12,7 @@ async fn test_build_wit() {
         .await
         .expect("Should be able to create a new lock file");
     let (_temp_cache, client) = common::get_client().await.unwrap();
-    let (pkg, version, bytes) = wkg_core::wit::build_package(
+    let (pkg, version, bytes) = wasm_pkg_core::wit::build_package(
         &WkgConfig::default(),
         fixture_path.join("wit"),
         &mut lock,
@@ -92,7 +92,7 @@ async fn test_bad_dep_failure() {
         .await
         .expect("Should be able to write the world file");
 
-    wkg_core::wit::build_package(
+    wasm_pkg_core::wit::build_package(
         &WkgConfig::default(),
         fixture_path.join("wit"),
         &mut lock,

crates/wkg-core/tests/fetch.rs → crates/wasm-pkg-core/tests/fetch.rs

@@ -2,7 +2,7 @@ use std::path::Path;
 
 use rstest::rstest;
 use tokio::process::Command;
-use wkg_core::{
+use wasm_pkg_core::{
     config::Config,
     lock::LockFile,
     wit::{self, OutputType},

crates/wkg/Cargo.toml

@@ -23,7 +23,7 @@ tracing-subscriber = { workspace = true }
 wasm-pkg-common = { workspace = true }
 wasm-pkg-client = { workspace = true }
 wit-component = { workspace = true }
-wkg-core = { workspace = true }
+wasm-pkg-core = { workspace = true }
 
 [dev-dependencies]
 base64 = { workspace = true }

crates/wkg/src/wit.rs

@@ -3,7 +3,7 @@ use std::path::{Path, PathBuf};
 
 use anyhow::Context;
 use clap::{Args, Subcommand};
-use wkg_core::{
+use wasm_pkg_core::{
     lock::LockFile,
     wit::{self, OutputType},
 };
@@ -88,7 +88,7 @@ impl BuildArgs {
     pub async fn run(self) -> anyhow::Result<()> {
         check_dir(&self.dir).await?;
         let client = self.common.get_client().await?;
-        let wkg_config = wkg_core::config::Config::load().await?;
+        let wkg_config = wasm_pkg_core::config::Config::load().await?;
         let mut lock_file = LockFile::load(false).await?;
         let (pkg_ref, version, bytes) =
             wit::build_package(&wkg_config, self.dir, &mut lock_file, client).await?;
@@ -115,7 +115,7 @@ impl FetchArgs {
     pub async fn run(self) -> anyhow::Result<()> {
         check_dir(&self.dir).await?;
         let client = self.common.get_client().await?;
-        let wkg_config = wkg_core::config::Config::load().await?;
+        let wkg_config = wasm_pkg_core::config::Config::load().await?;
         let mut lock_file = LockFile::load(false).await?;
         wit::fetch_dependencies(
             &wkg_config,
@@ -135,7 +135,7 @@ impl UpdateArgs {
     pub async fn run(self) -> anyhow::Result<()> {
         check_dir(&self.dir).await?;
         let client = self.common.get_client().await?;
-        let wkg_config = wkg_core::config::Config::load().await?;
+        let wkg_config = wasm_pkg_core::config::Config::load().await?;
         let mut lock_file = LockFile::load(false).await?;
         // Clear the lock file since we're updating it
         lock_file.packages.clear();