🤓 [wasm-parser] Add readers for core dump custom sections. #1012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itsrainy
force-pushed
the
rainy/coredump-parser
branch
from
24dda16
to
b01f99f
Compare
fitzgen
approved these changes
May 3, 2023
| /// The thread name | ||
| pub name: &'a str, | ||
| /// The stack frames for the core dump | ||
| pub frames: Vec<CoreDumpStackFrame>, |
There was a problem hiding this comment.
We might eventually want to split these out into a sub-reader and not eagerly parse and allocate a Vec for them, but this is fine for now.
Mossaka
pushed a commit
to Mossaka/wasm-tools-fork
that referenced
this pull request
May 29, 2023
…lliance#1012) * 🤓 [wasm-parser] Add readers for core dump custom sections. * Add a roundtrip test now that we have both parsing and encoding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are implemented following the spec in the tool-conventions repo.