wit-component: use library order to determine duplicate symbol priority #1258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses a couple of todo items in the shared-everything linking code in `wit-component`. Now, instead of erroring out on any duplicate symbols, we pick the first library in the order they were specified. Signed-off-by: Joel Dice <joel.dice@fermyon.com>
alexcrichton
approved these changes
Oct 20, 2023
dicej
added a commit
to dicej/wasm-tools
that referenced
this pull request
Oct 20, 2023
This is a follow-up to bytecodealliance#1258, in which I missed a chance to simplify the code a bit. Signed-off-by: Joel Dice <joel.dice@fermyon.com>
alexcrichton
pushed a commit
that referenced
this pull request
Oct 20, 2023
This is a follow-up to #1258, in which I missed a chance to simplify the code a bit. Signed-off-by: Joel Dice <joel.dice@fermyon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses a couple of todo items in the shared-everything linking code in
wit-component. Now, instead of erroring out on any duplicate symbols, we pick the first library in the order they were specified.