Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wit-parser): improve checking for stable feature gates #1689

Commits on Jul 30, 2024

  1. fix(wit-parser): improve checking for stable feature gates

    This commit introduces some extra checking for stabilized feature
    gates (i.e. `@since` & in-code `Stability::Stable`) with a version
    and/or feature specified.
    
    There are two primary changes:
    - Ensure that packages containing a `@since` annotation must have a
    version specified
    - Referring to a future unreleased package version in a `@since`
    annotation is an error
    
    In the past `Stability::Stable` feature gates were simply treated as
    `Unknown`, which hides the information necessary for downstream
    crates/consumers to use (and created the question around whether
    referring to future package versions is valid).
    
    Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
    vados-cosmonic committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    7ee44d9 View commit details
    Browse the repository at this point in the history