Validate functions are defined with function types #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was writing tests for module linking and hit a panic where functions weren't validated to be defined with function types, leading to a panic in a later unwrap.
yurydelendik
approved these changes
Jun 18, 2020
fitzgen
pushed a commit
to fitzgen/wasm-tools
that referenced
this pull request
Oct 21, 2020
dhil
pushed a commit
to dhil/wasm-tools
that referenced
this pull request
Oct 11, 2022
dhil
added a commit
to dhil/wasm-tools
that referenced
this pull request
Nov 9, 2023
Weekly merge with upstream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was writing tests for module linking and hit a panic where functions
weren't validated to be defined with function types, leading to a panic
in a later unwrap.