Make sure parse_all stops on Errors
#472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All uses of `Parser::parse_all` in the code immediately propagate errors and thus stop iteration. However the Iterator interface does not mandate this, and not handling the inner `Result` at all can way too easily lead to infinite loops.
|
Seems reasonable to me, thanks! And yeah if you'd like to add a fuzz target or update our fuzzers that'd be great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All uses of
Parser::parse_allin the code immediately propagate errorsand thus stop iteration. However the Iterator interface does not mandate
this, and not handling the inner
Resultat all can way too easily leadto infinite loops.
I found this while fuzzing
symbolicthat internally useswasmparser: getsentry/symbolic#500I see this crate does have some fuzz tests as well, but it would seem that this condition is never checked for? I can add something to verify this to the fuzz target here as well.