VisitOperator: implement delegates for Box<VisitOperator> #883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be awesome to have a wasmparser release once this lands. |
This is also fine because `Box` implements DerefMut. Pretty useful for people (like me) who have a `Box<dyn VisitOperator`, but can't use `&dyn` because of the borrowck limitations around how it handles HRTBs.
nagisa
force-pushed
the
visit-operator-default-impl-for-box
branch
from
19b6e9d
to
70239bb
Compare
alexcrichton
approved these changes
Jan 20, 2023
|
Sure yeah I can publish today. I think #882 will want a publish shortly after merging as well so I'll get that too. |
Merged
|
I stepped over myself a bit during publication but these crates are now all published on crates.io |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is also fine because
BoximplementsDerefMut. Pretty useful for people (like me) who have aBox<dyn VisitOperator>, but can't use&dynbecause of the borrowck limitations around how it handles HRTBs.