Implement export type ascription #913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit implements the change described in WebAssembly/component-model#155 and accounts for the update in WebAssembly/component-model#161. The internal plumbing for this change was relatively easy to implement and shouldn't cause too much of a burden even on Wasmtime as a consumer (it may not have to change at all). I'll be working on a follow-up for `wit-component` to use this new construct to fix the original underlying issue.
alexcrichton
force-pushed
the
export-type-ascription
branch
from
f32e513
to
e71f2b6
Compare
|
I should also mention that this changes the binary encoding of components and subsequently bumps the version in the binary format header. |
pchickey
approved these changes
Feb 7, 2023
peterhuene
approved these changes
Feb 7, 2023
alexcrichton
added a commit
to alexcrichton/wasm-tools
that referenced
this pull request
Feb 8, 2023
This commit leverages the type ascription added to the component model in bytecodealliance#913 to reimplement how exported instances work within `wit-component`. Instead of bag-of-exports they're now exported with instantiations of nested components, where each nested component imports functions and then simply reexports them with the appropriate type ascribed.
alexcrichton
added a commit
that referenced
this pull request
Feb 9, 2023
* Encode exported instances with nested components This commit leverages the type ascription added to the component model in #913 to reimplement how exported instances work within `wit-component`. Instead of bag-of-exports they're now exported with instantiations of nested components, where each nested component imports functions and then simply reexports them with the appropriate type ascribed. * Update crates/wit-component/src/encoding/types.rs Co-authored-by: Peter Huene <peter@huene.dev> --------- Co-authored-by: Peter Huene <peter@huene.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements the change described in
WebAssembly/component-model#155 and accounts for the update in WebAssembly/component-model#161. The internal plumbing for this change was relatively easy to implement and shouldn't cause too much of a burden even on Wasmtime as a consumer (it may not have to change at all). I'll be working on a follow-up for
wit-componentto use this new construct to fix the original underlying issue.