Update WebAssembly C API submodule to latest commit. #2579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the WebAssembly C API submodule (for `wasm.h`) to the latest commit out of master. This fixes the behavior of `wasm_name_new_from_string` such that it no longer copies the null character into the name, which caused unexpected failures when using the Wasmtime linker as imports wouldn't resolve when the null was present. Along with this change were breaking changes to `wasm_func_call`, the host callback signatures, and `wasm_instance_new` to take a vector type instead of a pointer to an unsized array. As a result, Wasmtime language bindings based on the C API will need to be updated once this change is pulled in. Fixes bytecodealliance#2211. Fixes bytecodealliance#2131.
|
Looks like I missed some new macros in wasm.h for the docs. I'll update. |
peterhuene
force-pushed
the
update-c-api
branch
from
3a91057 to
61705d6
Compare
Subscribe to Label Actioncc @peterhuene
This issue or pull request has been labeled: "wasmtime:c-api"
Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
alexcrichton
approved these changes
Jan 14, 2021
alexcrichton
added a commit
to alexcrichton/wasmtime-py
that referenced
this pull request
Jan 14, 2021
Updates this binding for bytecodealliance/wasmtime#2579
alexcrichton
added a commit
to alexcrichton/wasmtime-go
that referenced
this pull request
Jan 14, 2021
Updating these bindings to account for bytecodealliance/wasmtime#2579
alexcrichton
added a commit
to bytecodealliance/wasmtime-py
that referenced
this pull request
Jan 14, 2021
Updates this binding for bytecodealliance/wasmtime#2579
alexcrichton
added a commit
to bytecodealliance/wasmtime-go
that referenced
this pull request
Jan 14, 2021
* Update for recent C API changes Updating these bindings to account for bytecodealliance/wasmtime#2579 * Appease go vet
X-leaf7
added a commit
to X-leaf7/wasmtime-go
that referenced
this pull request
Jun 24, 2024
* Update for recent C API changes Updating these bindings to account for bytecodealliance/wasmtime#2579 * Appease go vet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the WebAssembly C API submodule (for
wasm.h) to thelatest commit out of master.
This fixes the behavior of
wasm_name_new_from_stringsuch that it no longercopies the null character into the name, which caused unexpected failures when
using the Wasmtime linker as imports wouldn't resolve when the null was
present.
Along with this change were breaking changes to
wasm_func_call, the hostcallback signatures, and
wasm_instance_newto take a vector type instead of apointer to an unsized array.
As a result, Wasmtime language bindings based on the C API will need to be
updated once this change is pulled in.
Fixes #2211.
Fixes #2131.