Updates to wasm2obj to produce stubs for C code #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 25, 2019
Closed
Closed
|
This approach of generating C files that one could then compile for the target is interesting. I'll need to think about this a bit to think about how this will work out. Another possible approach here would be if we could (cross-)compile cranelift-runtime for the target with something like --crate-type=staticlib, and then link that library with the wasm .o files. Then we could make calls into cranelift-runtime to initialize their VMContext contents. That might require |
m4b
reviewed
Jan 26, 2019
lib/obj/src/table.rs
Outdated
| pub fn emit_table(obj: &mut Artifact, index: usize) -> Result<(), String> { | ||
| let name = format!("_table_{}", index); | ||
| // FIXME: We need to initialize table using function symbols | ||
| obj.define(name, Vec::new()) |
There was a problem hiding this comment.
How come the vec is empty here ?
There was a problem hiding this comment.
FIXME comment explains the reason
yurydelendik
force-pushed
the
wasm2obj-update1
branch
2 times, most recently
from
0d3adda to
53ce2e7
Compare
yurydelendik
force-pushed
the
wasm2obj-update1
branch
from
53ce2e7 to
8bc90b4
Compare
yurydelendik
force-pushed
the
wasm2obj-update1
branch
from
8bc90b4 to
7c16594
Compare
yurydelendik
changed the title
yurydelendik
force-pushed
the
wasm2obj-update1
branch
from
7c16594 to
7b08a3d
Compare
yurydelendik
force-pushed
the
wasm2obj-update1
branch
from
7b08a3d to
17f1889
Compare
|
The PR is out of date. The functionality maybe covered later by interface types. Closing. |
grishasobol
pushed a commit
to grishasobol/wasmtime
that referenced
this pull request
Nov 29, 2021
howjmay
pushed a commit
to howjmay/wasmtime
that referenced
this pull request
Jan 24, 2022
* Implement module linking proposal This commit binds the support added in bytecodealliance#2472 to bring support for the module linking to this Go extension. The support here is similar to bytecodealliance/wasmtime-py#47, which is hooking up modules/instances to `Extern` as well as adding dedicated instance/module types. * Update bazel build * Try to fix a Windows CI issue
pchickey
pushed a commit
to pchickey/wasmtime
that referenced
this pull request
May 16, 2023
dhil
added a commit
to frank-emrich/wasmtime
that referenced
this pull request
Jul 12, 2023
frank-emrich
added a commit
to frank-emrich/wasmtime
that referenced
this pull request
Nov 7, 2023
mooori
pushed a commit
to mooori/wasmtime
that referenced
this pull request
Dec 20, 2023
…generation (bytecodealliance#46) * zkasm: split AdjustSp to separate variants for Reserve and Release stack space * ci: Fail builds when zkasm testing fails * zkasm: fix handling of clobbering registers * zkasm: stack alignment is 8 bytes Given that stack opeerates in numbers of aligned slots, rather then bytes, making sure that the stack is aligned to 8 bytes can’t be more wrong than aligning it to 1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes wasm2obj linkingfixes data segments generationP.S. some landed at #50