Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cranelift: update x64 inst_size_test #4991

Closed
wants to merge 1 commit into from

Conversation

pepyakin
Copy link
Contributor

@pepyakin pepyakin commented Oct 1, 2022

Running cargo test --all on the latest main (3fa545b) fails on my x86_64 machine, in particular, in the test modified. I am creating this PR to check my sanity. I expect the CI for this PR to fail.

@github-actions github-actions bot added cranelift Issues related to the Cranelift code generator cranelift:area:x64 Issues related to x64 codegen labels Oct 1, 2022
@pepyakin pepyakin closed this Oct 1, 2022
@pepyakin
Copy link
Contributor Author

pepyakin commented Oct 1, 2022

Yep, it does.

@pepyakin pepyakin deleted the pep-fix-tests branch October 1, 2022 11:48
@cfallin
Copy link
Member

cfallin commented Oct 1, 2022

Out of curiosity, were you seeing issues with a nightly compiler, or something else (local changes, etc)?

@afonso360
Copy link
Contributor

I ran into this issue as well, I think I tried the nightly compiler and it started failing, reverting back to stable works. (This was a few days ago so I'm not totally sure on the details)

@pepyakin
Copy link
Contributor Author

pepyakin commented Oct 1, 2022

Oh, yeah, I also thought it's nightly misbehaving, but running

rustup run --install stable cargo test -p cranelift-codegen -- isa::x64::inst::inst_size_test

resulted in the same panic! (rustc 1.64.0 (a55dd71d5 2022-09-19))

@afonso360
Copy link
Contributor

afonso360 commented Oct 1, 2022

That's weird, I tried updating my stable version, and I'm now on:

stable-x86_64-pc-windows-msvc (default)
rustc 1.64.0 (a55dd71d5 2022-09-19)

And running cargo +stable test -p cranelift-codegen -- isa::x64::inst::inst_size_test passes the test for me. 🤔

Edit: cargo +nightly test -p cranelift-codegen -- isa::x64::inst::inst_size_test does fail the test.

@lqd
Copy link
Contributor

lqd commented Oct 1, 2022

Could it be from the new enum layout from rust-lang/rust#94075 ?

@jameysharp
Copy link
Contributor

We're merging an identical patch now in #5188. I'm glad you all brought this up early so it wasn't a surprise!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cranelift:area:x64 Issues related to x64 codegen cranelift Issues related to the Cranelift code generator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants