Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release 9.0.0 branch: fix directory open rights #6479

Merged
merged 3 commits into from
May 31, 2023
Merged

release 9.0.0 branch: fix directory open rights #6479

merged 3 commits into from
May 31, 2023

Commits on May 30, 2023

  1. fix the directory base & inheriting rights 

    in order to work with wasi-testsuite, it needs to be possible to
path_open(dirfd, ".", ...) with the same rights reported in the
fdstat of that dirfd. When we report the Rights::all() set, both
FD_READ and FD_WRITE are set in the base rights, which results in
unix rejecting an openat2(dirfd, ".", O_RDWR) with EISDIR.

By not having the FD_READ and FD_WRITE rights present in the base
rights, the open syscall defaults to O_RDONLY, which is the only
access mode allowed for opening directories.
    Pat Hickey committed May 30, 2023
    Configuration menu
    Copy the full SHA
    51a2373 View commit details
    Browse the repository at this point in the history

  2. path_open of a directory with read and write succeeds on windows

    Pat Hickey committed May 30, 2023
    Configuration menu
    Copy the full SHA
    b38f08b View commit details
    Browse the repository at this point in the history

Commits on May 31, 2023

  1. fix test introduced as part of 9.0.2

    Pat Hickey committed May 31, 2023
    Configuration menu
    Copy the full SHA
    df778d8 View commit details
    Browse the repository at this point in the history