Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reexport wasmtime::hash_{map,set} from hashbrown internally #9328

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

fitzgen
Copy link
Member

@fitzgen fitzgen commented Sep 28, 2024

Some modules were using std::collections::{HashMap, HashSet} when they knew that they were only compiled when the std feature was enabled. But we need to use hashbrown in certain other places (Cranelift's e-graphs, pooling allocator's index allocator, etc.), so we should simply use hashbrown everywhere. This should reduce binary size some small amount, but also means that we never have to ask ourselves "which hash map should I import?" when adding a new hash map import: always use crate::hash_map::HashMap et al.

@fitzgen fitzgen requested a review from a team as a code owner September 28, 2024 23:20
@fitzgen fitzgen requested review from elliottt and removed request for a team September 28, 2024 23:20
Some modules were using `std::collections::{HashMap, HashSet}` when they knew
that they were only compiled when the `std` feature was enabled. But we need to
use `hashbrown` in certain other places (Cranelift's e-graphs, pooling
allocator's index allocator, etc.), so we should simply use `hashbrown`
everywhere. This should reduce binary size some small amount, but also means
that we never have to ask ourselves "which hash map should I import?" when
adding a new hash map import: always `use crate::hash_map::HashMap` et al.
@github-actions github-actions bot added wasmtime:api Related to the API of the `wasmtime` crate itself wasmtime:config Issues related to the configuration of Wasmtime wasmtime:ref-types Issues related to reference types and GC in Wasmtime labels Sep 29, 2024
Copy link

Subscribe to Label Action

cc @fitzgen

This issue or pull request has been labeled: "wasmtime:api", "wasmtime:config", "wasmtime:ref-types"

Thus the following users have been cc'd because of the following labels:

  • fitzgen: wasmtime:ref-types

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

Copy link

Label Messager: wasmtime:config

It looks like you are changing Wasmtime's configuration options. Make sure to
complete this check list:

  • If you added a new Config method, you wrote extensive documentation for
    it.

    Our documentation should be of the following form:

    Short, simple summary sentence.
    
    More details. These details can be multiple paragraphs. There should be
    information about not just the method, but its parameters and results as
    well.
    
    Is this method fallible? If so, when can it return an error?
    
    Can this method panic? If so, when does it panic?
    
    # Example
    
    Optional example here.
    
  • If you added a new Config method, or modified an existing one, you
    ensured that this configuration is exercised by the fuzz targets.

    For example, if you expose a new strategy for allocating the next instance
    slot inside the pooling allocator, you should ensure that at least one of our
    fuzz targets exercises that new strategy.

    Often, all that is required of you is to ensure that there is a knob for this
    configuration option in wasmtime_fuzzing::Config (or one
    of its nested structs).

    Rarely, this may require authoring a new fuzz target to specifically test this
    configuration. See our docs on fuzzing for more details.

  • If you are enabling a configuration option by default, make sure that it
    has been fuzzed for at least two weeks before turning it on by default.


To modify this label's message, edit the .github/label-messager/wasmtime-config.md file.

To add new label messages or remove existing label messages, edit the
.github/label-messager.json configuration file.

Learn more.

@alexcrichton alexcrichton added this pull request to the merge queue Sep 30, 2024
Merged via the queue into bytecodealliance:main with commit 018e52d Sep 30, 2024
39 checks passed
@fitzgen fitzgen deleted the wasmtime-crate-hash-map branch September 30, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wasmtime:api Related to the API of the `wasmtime` crate itself wasmtime:config Issues related to the configuration of Wasmtime wasmtime:ref-types Issues related to reference types and GC in Wasmtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants