Disable tail-call/relaxed-simd when fuzzing the spec interpreter #9360
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our copy of the reference interpreter does not implement the tail-call proposal, so fix OSS-Fuzz by disabling it. This technically should have been done in bytecodealliance#9336 when wasm-tools was updated to auto-try to enable this proposal by default, but alas I am not a human fuzzer so I waited until OSS-Fuzz found it.
|
Continuing to fuzz locally I've also disabled relaxed-simd here too |
alexcrichton
changed the title
abrown
approved these changes
Oct 2, 2024
|
@alexcrichton not right now, although I hope to change that soon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our copy of the reference interpreter does not implement the tail-call proposal, so fix OSS-Fuzz by disabling it. This technically should have been done in #9336 when wasm-tools was updated to auto-try to enable this proposal by default, but alas I am not a human fuzzer so I waited until OSS-Fuzz found it.
cc @conrad-watt we haven't updated our submodule in quite some time, but I figured this was a good a time as any to ask - have there been any major updates on your spec interpreter fork in the past year or so? If not no worries, but if so we can try to update too!