-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add I128 atomic support to the x64
backend
#9459
Conversation
b15472a
to
5a4083b
Compare
Subscribe to Label Action
This issue or pull request has been labeled: "cranelift", "cranelift:area:x64", "cranelift:meta", "fuzzing", "isle", "wasmtime:api", "wasmtime:config"
Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
Label Messager: wasmtime:configIt looks like you are changing Wasmtime's configuration options. Make sure to
To modify this label's message, edit the To add new label messages or remove existing label messages, edit the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, thanks!
I think CI might be stuck? Test macOS x86_64 (wasmtime-cli) seems to have been stuck on |
Never mind, it's managed to move on to the next step. |
It seems to have got stuck in the |
I've been seeing a lot of network issues in github actions the last week or so |
Rust is currently in the process of stabilising 128-bit atomics (rust-lang/rust#99069 (comment)), but Cranelift (and therefore
rustc_codegen_cranelift
) doesn't currently support 128-bit atomics.This PR adds IR support for 128-bit atomics and implements lowering them for the x64 backend using
cmpxchg16b
.