Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add I128 atomic support to the x64 backend #9459

Merged
merged 2 commits into from
Oct 14, 2024

Conversation

beetrees
Copy link
Contributor

Rust is currently in the process of stabilising 128-bit atomics (rust-lang/rust#99069 (comment)), but Cranelift (and therefore rustc_codegen_cranelift) doesn't currently support 128-bit atomics.

This PR adds IR support for 128-bit atomics and implements lowering them for the x64 backend using cmpxchg16b.

@beetrees beetrees requested review from a team as code owners October 13, 2024 17:03
@beetrees beetrees requested review from alexcrichton and fitzgen and removed request for a team October 13, 2024 17:03
@github-actions github-actions bot added cranelift Issues related to the Cranelift code generator cranelift:area:x64 Issues related to x64 codegen cranelift:meta Everything related to the meta-language. fuzzing Issues related to our fuzzing infrastructure isle Related to the ISLE domain-specific language wasmtime:api Related to the API of the `wasmtime` crate itself wasmtime:config Issues related to the configuration of Wasmtime labels Oct 13, 2024
Copy link

Subscribe to Label Action

cc @cfallin, @fitzgen

This issue or pull request has been labeled: "cranelift", "cranelift:area:x64", "cranelift:meta", "fuzzing", "isle", "wasmtime:api", "wasmtime:config"

Thus the following users have been cc'd because of the following labels:

  • cfallin: isle
  • fitzgen: fuzzing, isle

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

Copy link

Label Messager: wasmtime:config

It looks like you are changing Wasmtime's configuration options. Make sure to
complete this check list:

  • If you added a new Config method, you wrote extensive documentation for
    it.

    Our documentation should be of the following form:

    Short, simple summary sentence.
    
    More details. These details can be multiple paragraphs. There should be
    information about not just the method, but its parameters and results as
    well.
    
    Is this method fallible? If so, when can it return an error?
    
    Can this method panic? If so, when does it panic?
    
    # Example
    
    Optional example here.
    
  • If you added a new Config method, or modified an existing one, you
    ensured that this configuration is exercised by the fuzz targets.

    For example, if you expose a new strategy for allocating the next instance
    slot inside the pooling allocator, you should ensure that at least one of our
    fuzz targets exercises that new strategy.

    Often, all that is required of you is to ensure that there is a knob for this
    configuration option in wasmtime_fuzzing::Config (or one
    of its nested structs).

    Rarely, this may require authoring a new fuzz target to specifically test this
    configuration. See our docs on fuzzing for more details.

  • If you are enabling a configuration option by default, make sure that it
    has been fuzzed for at least two weeks before turning it on by default.


To modify this label's message, edit the .github/label-messager/wasmtime-config.md file.

To add new label messages or remove existing label messages, edit the
.github/label-messager.json configuration file.

Learn more.

Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks!

cranelift/codegen/src/isa/x64/inst/emit.rs Outdated Show resolved Hide resolved
@fitzgen fitzgen added this pull request to the merge queue Oct 14, 2024
@beetrees
Copy link
Contributor Author

I think CI might be stuck? Test macOS x86_64 (wasmtime-cli) seems to have been stuck on cargo fetch --locked for over an hour.

@beetrees
Copy link
Contributor Author

beetrees commented Oct 14, 2024

Never mind, it's managed to move on to the next step.

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Oct 14, 2024
@beetrees
Copy link
Contributor Author

It seems to have got stuck in the ./ci/run-tests.sh step now (first it was stuck at the very start of the step for around 30 mins, and now it's stuck at Compiling bytesize v1.3.0).

@fitzgen fitzgen added this pull request to the merge queue Oct 14, 2024
@fitzgen
Copy link
Member

fitzgen commented Oct 14, 2024

I've been seeing a lot of network issues in github actions the last week or so

Merged via the queue into bytecodealliance:main with commit 3036e79 Oct 14, 2024
69 checks passed
@beetrees beetrees deleted the atomic-128-x64 branch October 14, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cranelift:area:x64 Issues related to x64 codegen cranelift:meta Everything related to the meta-language. cranelift Issues related to the Cranelift code generator fuzzing Issues related to our fuzzing infrastructure isle Related to the ISLE domain-specific language wasmtime:api Related to the API of the `wasmtime` crate itself wasmtime:config Issues related to the configuration of Wasmtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants