Skip to content

Commit

Permalink
remove unused deps, force newer syn, some lint fixes (#1095)
Browse files Browse the repository at this point in the history
* chore(deps): remove unused dep from csharp bindgen

Signed-off-by: Victor Adossi <vadossi@cosmonic.com>

* chore(deps): remove unused dep from moonbit bindgen

Signed-off-by: Victor Adossi <vadossi@cosmonic.com>

* chore(deps): remove unused dep from markdown bindgen

Signed-off-by: Victor Adossi <vadossi@cosmonic.com>

* chore(deps): update syn dep to avoid regression

This commit addresses the regression noted upstream in `proc-macro2`
by way of `syn` (see dtolnay/proc-macro2 #484)

Signed-off-by: Victor Adossi <vadossi@cosmonic.com>

* chore(csharp): fix some lint warnings in csharp bindgen

Signed-off-by: Victor Adossi <vadossi@cosmonic.com>

---------

Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
  • Loading branch information
vados-cosmonic authored Nov 21, 2024
1 parent d92b53b commit 327efdc
Show file tree
Hide file tree
Showing 6 changed files with 8 additions and 13 deletions.
11 changes: 4 additions & 7 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ pulldown-cmark = { version = "0.9", default-features = false }
clap = { version = "4.3.19", features = ["derive"] }
indexmap = "2.0.0"
prettyplease = "0.2.20"
syn = { version = "2.0", features = ["printing"] }
syn = { version = "2.0.89", features = ["printing"] }

wasmparser = "0.220.0"
wasm-encoder = "0.220.0"
Expand Down
1 change: 0 additions & 1 deletion crates/csharp/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ doctest = false
test = false

[dependencies]
wasm-encoder = { workspace = true }
wit-bindgen-core = { workspace = true }
wit-component = { workspace = true }
wit-parser = { workspace = true }
Expand Down
4 changes: 3 additions & 1 deletion crates/csharp/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,7 @@ pub struct CSharp {
opts: Opts,
name: String,
usings: HashSet<String>,
#[allow(unused)]
interop_usings: HashSet<String>,
return_area_size: usize,
return_area_align: usize,
Expand Down Expand Up @@ -198,6 +199,7 @@ impl CSharp {
}
}

#[allow(unused)]
fn require_interop_using(&mut self, using_ns: &str) {
if !self.interop_usings.contains(using_ns) {
let using_ns_string = using_ns.to_string();
Expand Down Expand Up @@ -2691,7 +2693,7 @@ impl Bindgen for FunctionBindgen<'_, '_> {
));
}

Instruction::ListLower { element, realloc } => {
Instruction::ListLower { element, .. } => {
let Block {
body,
results: block_results,
Expand Down
1 change: 0 additions & 1 deletion crates/markdown/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,3 @@ heck = { workspace = true }
pulldown-cmark = { workspace = true }
clap = { workspace = true, optional = true }
wit-bindgen-core = { workspace = true }
wit-component = { workspace = true }
2 changes: 0 additions & 2 deletions crates/moonbit/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@ through the `wit-bindgen-cli` crate.
[dependencies]
anyhow = { workspace = true }
wit-bindgen-core = { workspace = true }
wit-component = { workspace = true }
wasm-metadata = { workspace = true }
heck = { workspace = true }
clap = { workspace = true, optional = true }

Expand Down

0 comments on commit 327efdc

Please sign in to comment.