Update string representation to not char*
#665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `uint8_t*` to represent that it's not a normal `char*` since it's neither nul-terminated and it may also contain interior nul characters. Closes bytecodealliance#662
|
@Mossaka would you be able to assist with the Go failures here? I could add some exceptions to ignore the tests but that seems infeasible in this case because it'd break all usage of strings from Go |
|
Yup I'll take a look at today. Thanks for letting me know |
|
Thanks! Not super urgent, but there may also be a simple fix too |
Signed-off-by: Jiaxiao Zhou (Mossaka) <duibao55328@gmail.com>
|
@alexcrichton I just added a commit, should fix the Go failures. |
Mossaka
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
uint8_t*to represent that it's not a normalchar*since it's neither nul-terminated and it may also contain interior nul characters.Closes #662