Fix the exports key for packages-with-versions
#677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Noticing that the package name is no longer part of the key; would this cause an issue when exporting two interfaces with the same name but different packages, e.g. |
|
Oh the package name should still be there, that's a mistake if I left it out by accident. My intention was that previously you'd specify |
Previously one location looking up `exports` would account for the version and another wouldn't which caused the `ERROR` case to leak through by accident. These are now kept in sync to ensure that the right errors get surfaced.
alexcrichton
force-pushed
the
fix-verisons
branch
from
22eec15 to
092068b
Compare
|
Ok, I see now. It's |
dicej
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously one location looking up
exportswould account for the version and another wouldn't which caused theERRORcase to leak through by accident. These are now kept in sync to ensure that the right errors get surfaced.