-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(c#): Add smoke runtime test #764
Conversation
The module is in a recursive loop. From what I can tell it appears to be because the import and export have the same name and |
RIght, this problem will be fixed when the new WasmImportLinkage attribute is implemented in the compiler. I'm doing that at the moment, but some other RyuJit changes are slowing me up. |
Makes sense now, missed that it was for this! Thanks! |
link to the wasmimportlinkage dotnet/runtime#94615 |
Thanks, the merge is in with the new attribute. I will try to get the PR for the compiler in this evening. |
This should work after #791 |
7107378
to
0eb1d0f
Compare
I've rebased but error looks related to something about pulling the correct packages:
@yowl any ideas? |
0eb1d0f
to
3fbdf77
Compare
Seems like it is invalid for some reason: ERROR 403: Time-Limited URL validation failed |
I think there must be some maintenance or something going on, try in 30 minutes, the link from https://dev.azure.com/dnceng/public/_artifacts/feed/dotnet-experimental/NuGet/runtime.win-x64.Microsoft.DotNet.ILCompiler.LLVM/overview/9.0.0-alpha.1.23619.1 is not working. |
thanks, I reproduced this locally but it does seem temporary. Will try again later in the day |
527a47e
to
74b402b
Compare
Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
74b402b
to
bccc48a
Compare
Alright does seem like it was a flake. Test is passing now 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
No description provided.