Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(c#): Add smoke runtime test #764

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

jsturtevant
Copy link
Collaborator

No description provided.

@jsturtevant
Copy link
Collaborator Author

The module is in a recursive loop. From what I can tell it appears to be because the import and export have the same name and * is used in dllimport. I am guessing that it is picking our dll instead of the imported?

https://github.com/bytecodealliance/wit-bindgen/blob/d40ab04c5eed6e916b547a0eac70e4ac0c67e0cb/crates/csharp/src/lib.rs#L667C6-L676

@yowl
Copy link
Collaborator

yowl commented Nov 23, 2023

RIght, this problem will be fixed when the new WasmImportLinkage attribute is implemented in the compiler. I'm doing that at the moment, but some other RyuJit changes are slowing me up.

@jsturtevant
Copy link
Collaborator Author

Makes sense now, missed that it was for this! Thanks!

@jsturtevant
Copy link
Collaborator Author

link to the wasmimportlinkage dotnet/runtime#94615

@yowl
Copy link
Collaborator

yowl commented Nov 27, 2023

Thanks, the merge is in with the new attribute. I will try to get the PR for the compiler in this evening.

@jsturtevant
Copy link
Collaborator Author

dotnet/runtimelab#2444

@jsturtevant
Copy link
Collaborator Author

This should work after #791

@jsturtevant
Copy link
Collaborator Author

I've rebased but error looks related to something about pulling the correct packages:

C:\Users\runneradmin\AppData\Local\Microsoft\dotnet\sdk\8.0.100\NuGet.targets(156,5): error : Failed to download package 'runtime.win-x64.Microsoft.DotNet.ILCompiler.LLVM.9.0.0-alpha.1.23619.1' from 'https://pkgs.dev.azure.com/dnceng/9ee6d478-d288-47f7-aacc-f6e6d082ae6d/_packaging/fe324174-469a-4296-a9cb-1fd885bb6f2b/nuget/v3/flat2/runtime.win-x64.microsoft.dotnet.ilcompiler.llvm/9.0.0-alpha.1.23619.1/runtime.win-x64.microsoft.dotnet.ilcompiler.llvm.9.0.0-alpha.1.23619.1.nupkg'. [D:\a\wit-bindgen\wit-bindgen\target\runtime-tests\strings\csharp-strings\Strings.csproj]

@yowl any ideas?

@yowl
Copy link
Collaborator

yowl commented Jan 2, 2024

Seems like it is invalid for some reason:

ERROR 403: Time-Limited URL validation failed

@yowl
Copy link
Collaborator

yowl commented Jan 2, 2024

I think there must be some maintenance or something going on, try in 30 minutes, the link from https://dev.azure.com/dnceng/public/_artifacts/feed/dotnet-experimental/NuGet/runtime.win-x64.Microsoft.DotNet.ILCompiler.LLVM/overview/9.0.0-alpha.1.23619.1 is not working.

@jsturtevant
Copy link
Collaborator Author

thanks, I reproduced this locally but it does seem temporary. Will try again later in the day

@jsturtevant jsturtevant force-pushed the runtimetests branch 2 times, most recently from 527a47e to 74b402b Compare January 2, 2024 23:52
Signed-off-by: James Sturtevant <jsturtevant@gmail.com>
@jsturtevant
Copy link
Collaborator Author

Alright does seem like it was a flake. Test is passing now 🚀

Copy link
Collaborator

@yowl yowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jsturtevant jsturtevant merged commit e77eaec into bytecodealliance:main Jan 3, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants