Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add windows crash_dump support & sys split #713

Merged
merged 2 commits into from
Nov 28, 2024
Merged

add windows crash_dump support & sys split #713

merged 2 commits into from
Nov 28, 2024

Conversation

kulukami
Copy link
Collaborator

Summary

This PR fixes/implements the following bugs/features

  • update cargo edition into 2021 (rust 1.82.0)
  • split sys utils into unix and windows
  • windows plugin exit code 0xc000013a after recived SIGINT while user execute nssm.exe restart agent (only on exit error code, no affect on running stage)
  • regist exception handler with crash dump for windows

@kulukami kulukami requested a review from yoloyyh November 25, 2024 03:24
yoloyyh
yoloyyh reviewed Nov 26, 2024
View reviewed changes
plugins/lib/rust/src/sys/unix.rs
})))
}

pub fn get_high_writer() -> Arc<Mutex<BufWriter<File>>> {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里应该使用HIGH_PRIORIT_FD吧

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@kulukami kulukami requested a review from yoloyyh November 27, 2024 08:02
@kulukami kulukami merged commit 88aa15a into main Nov 28, 2024
1 check passed
@kulukami kulukami self-assigned this Nov 28, 2024
@kulukami kulukami added the enhancement New feature or request label Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoloyyh yoloyyh yoloyyh approved these changes

Assignees

@kulukami kulukami

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kulukami @yoloyyh