Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add AddAssign operator to ByteSize #22

Merged
merged 8 commits into from
Jul 30, 2021
Merged

add AddAssign operator to ByteSize #22

merged 8 commits into from
Jul 30, 2021

Conversation

pmnoxx
Copy link
Contributor

@pmnoxx pmnoxx commented Feb 26, 2021 •
edited
Loading

While using ByteSize, I found out that I was missing AddAssign operator.

This pr should allow the following

let mut x = ByteSize::mb(1);
let y = ByteSize::mb(1);
x += y;

@pmnoxx
Copy link
Contributor Author

pmnoxx commented Feb 26, 2021

@hyunsik can you take a look?

@hyunsik hyunsik self-requested a review July 30, 2021 21:36
hyunsik
hyunsik approved these changes Jul 30, 2021
View reviewed changes
Copy link
Collaborator

@hyunsik hyunsik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry for a late review. The patch looks great to me. It made the code simpler with more features.

@hyunsik hyunsik merged commit 8290027 into bytesize-rs:master Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyunsik hyunsik hyunsik approved these changes

Assignees

@pmnoxx pmnoxx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pmnoxx @hyunsik