Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: support esm syntax #348

Merged
merged 4 commits into from
Oct 9, 2024
Merged

chore: support esm syntax #348

merged 4 commits into from
Oct 9, 2024

Conversation

rhettjay
Copy link
Member

@rhettjay rhettjay commented Oct 9, 2024

We don't need the isInstalled function because pino already checks for the transport package and will fail if it doesn't exist (i.e. it's a redundant blocker). Given this I also added the sync: true flag which is the recommended config for jest due the async blocker.

Additionally refactoring tsconfigs for cjs/esm interop. Maybe one day we'll not need to care about this. I pray this day comes soon.

Bumped node support to 20+ (if you're on 18, 20 should be an easy move). This subsequently bumps the version to 2.

@rhettjay rhettjay marked this pull request as ready for review October 9, 2024 07:12
@rhettjay rhettjay requested a review from stuft2 October 9, 2024 15:12
@rhettjay rhettjay merged commit 89d9f1a into main Oct 9, 2024
8 checks passed
@rhettjay rhettjay deleted the esm-checks branch October 9, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants