Implement ValidateAlgorithmSettings for hyperopt (kubeflow#1130)

c-bata · Apr 9, 2020 · 762e6a0 · 762e6a0
1 parent ab3dab0
commit 762e6a0
Show file tree

Hide file tree

Showing 5 changed files with 18 additions and 13 deletions.
diff --git a/pkg/suggestion/v1alpha3/chocolate/base_chocolate_service.py b/pkg/suggestion/v1alpha3/chocolate/base_chocolate_service.py
@@ -1,11 +1,11 @@
-import json
-import numpy as np
 import chocolate as choco
 import logging
 import base64
 
-from pkg.suggestion.v1alpha3.internal.search_space import *
-from pkg.suggestion.v1alpha3.internal.trial import *
+from pkg.suggestion.v1alpha3.internal.search_space import (
+    INTEGER, DOUBLE, CATEGORICAL, DISCRETE, MAX_GOAL,
+)
+from pkg.suggestion.v1alpha3.internal.trial import Assignment
 
 logger = logging.getLogger(__name__)
 

diff --git a/pkg/suggestion/v1alpha3/hyperopt/base_hyperopt_service.py b/pkg/suggestion/v1alpha3/hyperopt/base_hyperopt_service.py
@@ -2,14 +2,17 @@
 import numpy as np
 import logging
 
-from pkg.suggestion.v1alpha3.internal.search_space import *
-from pkg.suggestion.v1alpha3.internal.trial import *
+from pkg.suggestion.v1alpha3.internal.search_space import (
+    INTEGER, DOUBLE, CATEGORICAL, DISCRETE, MAX_GOAL,
+)
+from pkg.suggestion.v1alpha3.internal.trial import Assignment
 
 logger = logging.getLogger(__name__)
 
 TPE_ALGORITHM_NAME = "tpe"
 RANDOM_ALGORITHM_NAME = "random"
 
+
 class BaseHyperoptService(object):
     def __init__(self, algorithm_name=TPE_ALGORITHM_NAME, random_state=None, search_space=None):
         self.algorithm_name = algorithm_name
@@ -64,7 +67,6 @@ def create_fmin(self):
 
         self.fmin.catch_eval_exceptions = False
 
-
     def getSuggestions(self, trials, request_number):
         """
         Get the new suggested trials with the given algorithm.

diff --git a/pkg/suggestion/v1alpha3/hyperopt_service.py b/pkg/suggestion/v1alpha3/hyperopt_service.py
@@ -39,6 +39,9 @@ def GetSuggestions(self, request, context):
             parameter_assignments=Assignment.generate(new_assignments)
         )
 
+    def ValidateAlgorithmSettings(self, request, context):
+        return api_pb2.ValidateAlgorithmSettingsReply()
+
 
 class OptimizerConfiguration(object):
     def __init__(self, random_state=None):

diff --git a/pkg/suggestion/v1alpha3/internal/__init__.py b/pkg/suggestion/v1alpha3/internal/__init__.py
diff --git a/pkg/suggestion/v1alpha3/skopt/base_skopt_service.py b/pkg/suggestion/v1alpha3/skopt/base_skopt_service.py
@@ -1,11 +1,11 @@
-import json
-import numpy as np
-import skopt
+import datetime
 import logging
+import skopt
 
-from pkg.suggestion.v1alpha3.internal.search_space import *
-from pkg.suggestion.v1alpha3.internal.trial import *
-import datetime
+from pkg.suggestion.v1alpha3.internal.search_space import (
+    INTEGER, DOUBLE, CATEGORICAL, DISCRETE, MAX_GOAL,
+)
+from pkg.suggestion.v1alpha3.internal.trial import Assignment
 
 logger = logging.getLogger(__name__)