-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QCHECK_LONG_FACTOR environment variable #220
Conversation
just a remark, there is already the notion of |
I was not aware of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this is a very reasonable request of being able to configure long_factor
through an environment variable. Code looks good and clean too. My heartfelt thanks (really!) for including tests of the new functionality! 🙏
If I'm not mistaken, this only adds the functionality for QCheck2 - which leaves us in a bit of a limbo. Could I persuade you to copy-paste the functionality so that it will also work for QCheck tests? (the unit-tests for QCheck should largely also just be a copy-paste job)
Finally, you are also welcome to add a CHANGELOG entry for the new functionality.
You're absolutely right. |
Great, thank! |
In #142 we introduced a
QCHECK_COUNT
environment variable. It is very useful to debug flaky tests by running a dedicated pipeline with a lot higherQCHECK_COUNT
. We decided that the~count
in aTest.make
overrides the environment variable (which I think is fine), but, there is no easy way to conditionally increase these given counts.I propose another environment variable
QCHECK_COUNT_MULTIPLIER
to increase the~count
value.