Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Option for skipping recent artifacts #27

Merged
merged 9 commits into from
May 8, 2020

Conversation

gomorizsolt
Copy link
Collaborator

@gomorizsolt gomorizsolt commented May 6, 2020

Issue #26.

Changes:

  • the skip-recent option allows users to define the number of artifacts that should be prevented from the removal (even if they're older than the specified age)
  • improvements (log the artifact's name alongside its id, created a map of the available options)

@gomorizsolt gomorizsolt marked this pull request as ready for review May 6, 2020 09:24
@thisismydesign
Copy link
Member

CI falied

Copy link
Member

@thisismydesign thisismydesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also include this in the example in the README. Let's comment out skip-tags and skip-recent there and mark them as optional.

@gomorizsolt
Copy link
Collaborator Author

Let's also include this in the example in the README. Let's comment out skip-tags and skip-recent there and mark them as optional.

Thanks, good point.

@gomorizsolt
Copy link
Collaborator Author

gomorizsolt commented May 7, 2020

CI falied

Yep, it failed because the request quota was exceeded:

https://github.com/c-hive/gha-remove-artifacts/runs/648978726#step:7:28

Now it's fine. Though it's interesting since the requests are throttled.

@gomorizsolt gomorizsolt merged commit 9fa79d7 into master May 8, 2020
@gomorizsolt gomorizsolt deleted the feature-option-for-skip-recent-artifacts branch May 8, 2020 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants