Update header check in Slocup.py to work with the new gliders #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 30, 2022 10:39
Add two 'and' statements to the 'if' loops in the _check_diag_header function in slocum.py, to account for the new header values for data from the new Slocum G3 gliders.
|
Great Hayley (plus or minus getting the logic to work). I think we should add a small G3 file to the test data set so we can keep testing this, but that can wait until you have it working... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add two 'and' statements to the 'if' loops in the _check_diag_header
function in slocum.py, to account for the new header values for
data from the new Slocum G3 gliders.