Fix slocum #105
Merged
Fix slocum #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvdosser
reviewed
Jul 4, 2022
| raise ValueError('Diagnostic header check failed.') | ||
|
|
||
| endian = 'be' | ||
| data = binaryData.read(f'uint{endian}:16') | ||
| _log.debug('Checking endianness %s == 4660 or 13330', data) |
There was a problem hiding this comment.
I don't think there are actually any different values in the new headers, I think it was just reading them incorrectly. In other words, we don't need the check for 13330.
There was a problem hiding this comment.
This just lets us check without flipping the bytes...
There was a problem hiding this comment.
I just realized that as I was updating the code, it's actually a nice way to do the check. And everything is working! Thanks for making the changes.
There was a problem hiding this comment.
Ha, it will all be obsolete in a day or two if we switch to dbdreader...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new slocum files changed the endianness. This change checks for endianness and then reads the files in w/ the appropriate endinaness..
This needs an example
maria_997to be added to the tests, but I don't have the whole setup yet...