Modified seaexplorer.py so it will run without .gli files present #107
Conversation
| @@ -99,7 +100,6 @@ def raw_to_rawnc(indir, outdir, deploymentyaml, incremental=True, | |||
| continue | |||
|
|
|||
| badfiles = [] | |||
| goodfiles = [] | |||
There was a problem hiding this comment.
Why does badfiles not get the same treatment?
There was a problem hiding this comment.
I had been thinking we wanted each type of bad file logged separately, but if that's not the case then certainly it can get the same treatment.
| _log.warning(f'No valid unprocessed seaexplorer files found in' | ||
| f'{indir}') | ||
| return False | ||
| if not goodfiles: |
There was a problem hiding this comment.
I guess this is fine. I'd still prefer some explanation of what this fixes and why this is the correct fix. Because this seems like it should be fine.
There was a problem hiding this comment.
Changing the location of the if not goodfiles: statement prevents the function from returning a value of False before running the pld1 for-loop. The return False was previously within the for rawsub in ['raw', 'sub']: for-loop, meaning that a value of False could be returned before any pld1 files were processed. Moving the if not goodfiles: statement out of that for-loop ensures that we will process both gld and pld1 files before the function returns anything.
No description provided.