Fixed time_profile variable units to be IOOS compliant. #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The variable time_profile had units that were e.g., 'seconds from 2022-12-01' but with the time changing for each profile. Code has been modified so the correct units will show up for all profiles. This fix also solved an issue where the value of time_profile was showing up as zero for some reason.
Codecov ReportBase: 77.49% // Head: 77.49% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #141 +/- ##
=======================================
Coverage 77.49% 77.49%
=======================================
Files 7 7
Lines 1271 1271
=======================================
Hits 985 985
Misses 286 286 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Can we add a test for this. e.g. test that the times are what we want when read back in? |
|
I don't think we have any tests for the profile netcdf files right now, or for the gridded files. Do you want me to write one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The variable time_profile had units that were e.g., 'seconds from 2022-12-01' but with the time changing for each profile. Code has been modified so the
correct units will show up for all profiles. This
fix also solved an issue where the value of time_profile was showing up as zero for some reason.