Fix for SeaExplorer code to avoid interpolating over large gaps #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gaps This fix uses the same `utils.findgaps` function as the Slocum code, and only interpolates over gaps that are larger than the user-specified parameter `maxgap`.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #150 +/- ##
==========================================
+ Coverage 79.62% 79.65% +0.02%
==========================================
Files 7 7
Lines 1374 1376 +2
==========================================
+ Hits 1094 1096 +2
Misses 280 280
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
callumrollo
requested changes
Apr 24, 2023
pyglider/seaexplorer.py
Outdated
| @@ -387,6 +387,10 @@ def raw_to_timeseries(indir, outdir, deploymentyaml, kind='raw', | |||
| val = np.datetime64("1970-01-01") + val_us | |||
| else: | |||
| val = np.interp(time_timebase.astype(float), time_var.astype(float), var_non_nan) | |||
|
|
|||
| # interpolate only over those gaps that are smaller than 'maxgap' | |||
| tg_ind = utils.find_gaps(time_var.astype(float),time_timebase.astype(float),maxgap) | |||
There was a problem hiding this comment.
I believe this should be de-intented by one level so that it also applies the max gap check to variables with the datetime dtype
callumrollo
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix uses the same
utils.findgapsfunction as the Slocum code, and only interpolates over gaps that are larger than the user-specified parametermaxgap.