Correct a bug in ncprocess for u,v metadata check #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed the `elif` statement that checks if there is a fill value for u and v in the metadata to prevent a key error if u and v aren't in the metadata at all.
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #158 +/- ##
=======================================
Coverage 79.65% 79.65%
=======================================
Files 7 7
Lines 1376 1376
=======================================
Hits 1096 1096
Misses 280 280 ☔ View full report in Codecov by Sentry. |
jklymak
reviewed
Jun 16, 2023
jklymak
approved these changes
Jun 16, 2023
|
Feel free to self merge when tests done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the
elifstatement that checks if there is a fill value for u and v in the metadata to prevent a key error if u and v aren't listed as variables in the metadata at all.