Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyglider additions, adding argopandas as submodule #51

Merged
merged 1 commit into from
Jun 16, 2022

Conversation

juliaputko
Copy link
Contributor

No description provided.

@jklymak
Copy link
Member

jklymak commented Apr 28, 2022

I'm confused why we would add argo stuff to this repo?

@juliaputko
Copy link
Contributor Author

juliaputko commented Apr 29, 2022 via email

@jklymak
Copy link
Member

jklymak commented Apr 29, 2022

pyglider definitely should not have anything about argo floats in it ;-). I think it is probably also bad to have the website stuff in here as well, but that's just historic. But a module like this should be pip install module on the machine that has the python environment, not vendored into this library. Hopefully that makes sense.

Copy link
Collaborator

@hvdosser hvdosser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to remove argo stuff and make a separate pull request for slocum.py and seaexplorer.py.

@jklymak jklymak merged commit 4afbc5e into c-proof:main Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants