Changing default ordering of extensions for fetching ebooks #103
Conversation
lissyx
force-pushed
the
change-extensions-order
branch
6 times, most recently
from
8e95792 to
b7c5136
Compare
lissyx
force-pushed
the
change-extensions-order
branch
from
b7c5136 to
35ec513
Compare
|
@c-w Done, tell me if the wording is okay to you :) |
|
@c-w I'm also adding the |
lissyx
force-pushed
the
change-extensions-order
branch
from
35ec513 to
5da8e67
Compare
|
I'd ask that you add a |
|
Sure, I'll add that. |
lissyx
force-pushed
the
change-extensions-order
branch
from
5da8e67 to
e7b5e65
Compare
|
@MasterOdin Re-pushed with the command line argument :-) |
lissyx
force-pushed
the
change-extensions-order
branch
from
e7b5e65 to
2cac5ed
Compare
|
|
||
| extensions = text._format_download_uri(12345, prefer_ascii=True) | ||
| self.assertEqual(extensions.split('/')[-1], ascii_filename) | ||
|
|
There was a problem hiding this comment.
Can you add a test where the files are ['12345-8.txt', '12345.txt'] so that we have a test to verify that we prefer -8 over nothing by default.
There was a problem hiding this comment.
Right, should be addressed now :)
|
Looks good! We'll want to bump the version to 0.7.0 for this since it's a slight backwards breaking change. |
lissyx
force-pushed
the
change-extensions-order
branch
from
2cac5ed to
c553017
Compare
|
@MasterOdin If you think we should not break backward compatibility, I'd be happy to change the behavior so that the default path stays the same as before :) |
|
I'm fine breaking it and this is probably preferable for most use cases, it's just something to be aware of and that it should be noted on the release page when a new release is cut. |
|
Then I guess someone needs to merge it, if it's good for you :-) |
lissyx
force-pushed
the
change-extensions-order
branch
from
c553017 to
e7c73a2
Compare
|
Re-pushed, updating the version field. |
|
Thanks a lot for the PR, @lissyx! |
Resolves #102