Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(service): Add M-Pesa Express Query service #108

Merged
merged 11 commits into from
Jul 8, 2024
Merged

feat(service): Add M-Pesa Express Query service #108

merged 11 commits into from
Jul 8, 2024

Conversation

itsyaasir
Copy link
Collaborator

@itsyaasir itsyaasir commented Jan 29, 2024 •
edited
Loading

Closes #101

@itsyaasir itsyaasir changed the title feat!(service): Add M-Pesa Express Query service feat(service): Add M-Pesa Express Query service Jan 29, 2024
@itsyaasir itsyaasir linked an issue Jan 29, 2024 that may be closed by this pull request
Implement Mpesa Express Query service #101
Closed
@itsyaasir itsyaasir self-assigned this Jan 29, 2024
@itsyaasir itsyaasir requested a review from c12i January 29, 2024 04:58
@c12i c12i added the port-to-v1 The changes in this PR should be ported over to the `v1` maintenance branch label Jan 29, 2024
c12i
c12i requested changes Jan 30, 2024
View reviewed changes
Copy link
Owner

@c12i c12i left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other Suggestion: rename docs/client/express_request.md to docs/client/express.md,git mv should do the trick to maintain commit history for the file

src/services/express/express_query.rs Outdated Show resolved Hide resolved
src/services/express/express_query.rs Outdated Show resolved Hide resolved
@c12i c12i removed the port-to-v1 The changes in this PR should be ported over to the `v1` maintenance branch label Jan 30, 2024
@c12i
Copy link
Owner

c12i commented Jan 30, 2024

On second thought, this change cannot be ported to v1 because of the updated feature name from express_request to express

c12i
c12i reviewed Jan 30, 2024
View reviewed changes
Copy link
Owner

@c12i c12i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be sure to update the table in the README.md file

itsyaasir and others added 2 commits February 1, 2024 09:41
@itsyaasir @c12i
Apply suggestions from code review
f1119e0 
Co-authored-by: Collins Muriuki <hello@collinsmuriuki.xyz>
@itsyaasir
chore(doc): Update readme
8c32ae3
@itsyaasir itsyaasir requested a review from c12i February 5, 2024 13:54
@c12i
Copy link
Owner

c12i commented Feb 6, 2024

Failing doc tests are at it again

@itsyaasir itsyaasir merged commit a590bcd into master Jul 8, 2024
10 of 12 checks passed
@itsyaasir itsyaasir deleted the itsyaasir/feat/add-mpesa-express-query branch July 8, 2024 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c12i c12i c12i approved these changes

Assignees

@itsyaasir itsyaasir

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Mpesa Express Query service
2 participants
@itsyaasir @c12i