Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement and Refactor Search Functionality for Tutorials #150

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

lokeshwar777
Copy link
Collaborator

Description

This PR introduces significant updates and refinements to the app's search functionality. Key changes include:

  • Refactored the codebase to optimize the structure and logic for populating tutorials.
  • Added a /search route to handle search results.
  • Implemented search functionality within the MainNavbar and MiniNavbar components.
  • Enhanced the SearchResultsComponent to process and display search queries efficiently.
  • Simplified the logic for populating search results to ensure better performance.
  • Added a fetchAndIndexTutorials action to the App component to streamline tutorial fetching and indexing.
  • Refactored methods within the Elasticlunr class to improve search functionality.

Related Issue

This PR is related to an issue that aims to implement and optimize the search functionality for tutorials based on tags and titles using Elastic Lunr.
Closes #149

Motivation and Context

These changes are necessary to provide users with a robust search experience. The existing search functionality was incomplete, making it difficult for users to find tutorials by tags and titles. By fully implementing Elastic Lunr, the app now offers a faster and more accurate search mechanism, improving overall user experience.

How Has This Been Tested?

Tested locally to ensure that the search functionality works as expected across various components.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fully Implement Elastic Lunr for Enhanced Tutorial Search
2 participants