Don't use the sync beforehand - the manager.Make takes care of that

c4dt · Mar 5, 2024 · 84c01b4 · 84c01b4
1 parent 73bff7b
commit 84c01b4
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 6 deletions.
diff --git a/core/txn/pool/controller/action.go b/core/txn/pool/controller/action.go
@@ -62,11 +62,6 @@ func (a *addAction) Execute(ctx node.Context) error {
 
 	manager := getManager(signer, a.client)
 
-	err = manager.Sync()
-	if err != nil {
-		return xerrors.Errorf("failed to sync manager: %v", err)
-	}
-
 	tx, err := manager.Make(args...)
 	if err != nil {
 		return xerrors.Errorf("creating transaction: %v", err)

diff --git a/core/txn/pool/controller/controller.go b/core/txn/pool/controller/controller.go
@@ -63,7 +63,7 @@ func (miniController) OnStop(inj node.Injector) error {
 	return nil
 }
 
-// client return monotically increasing nonce
+// client returns monotonically increasing nonce
 //
 // - implements signed.Client
 type client struct {