Skip to content

Commit

Permalink
Fix Clang compiler warnings
Browse files Browse the repository at this point in the history
When building using a newer Clang with additional diagnostics
the following warnings are given:
 -Wunused-but-set-variable
 -Wstrict-prototypes
These issues are corrected in this commit.

Reproducable using:
CC="clang-13" CFLAGS="-Wall -pedantic" cmake ..
  • Loading branch information
bjosv committed Sep 22, 2023
1 parent 91405ad commit 8d59147
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 8 deletions.
2 changes: 0 additions & 2 deletions src/slug.c
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,6 @@ int r3_slug_parse(r3_slug_t *s, const char *needle, int needle_len, const char *
return 0;
}

int cnt = 0;
int state = 0;
const char * p = offset;

Expand Down Expand Up @@ -122,7 +121,6 @@ int r3_slug_parse(r3_slug_t *s, const char *needle, int needle_len, const char *
if (s->pattern) {
s->pattern_len = p - s->pattern;
}
cnt++;
state--;
p++;
break;
Expand Down
6 changes: 3 additions & 3 deletions tests/bench.c
Original file line number Diff line number Diff line change
Expand Up @@ -17,15 +17,15 @@



unsigned long unixtime() {
unsigned long unixtime(void) {
struct timeval tp;
if (gettimeofday((struct timeval *) &tp, (NULL)) == 0) {
return tp.tv_sec;
}
return 0;
}

double microtime() {
double microtime(void) {
struct timeval tp;
long sec = 0L;
double msec = 0.0;
Expand Down Expand Up @@ -93,7 +93,7 @@ void bench_append_csv(char *filename, int countOfB, ...) {



int main()
int main(void)
{
R3Node * n = r3_tree_create(1);

Expand Down
4 changes: 2 additions & 2 deletions tests/bench.h
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,9 @@ typedef struct {
double end;
} bench;

unsigned long unixtime();
unsigned long unixtime(void);

double microtime();
double microtime(void);

void bench_start(bench *b);

Expand Down
2 changes: 1 addition & 1 deletion tests/check_tree.c
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,7 @@ START_TEST (test_node_construct_and_free)
}
END_TEST

static R3Node * create_simple_str_tree() {
static R3Node * create_simple_str_tree(void) {
R3Node * n;
n = r3_tree_create(10);
r3_tree_insert_path(n, "/zoo", NULL);
Expand Down

0 comments on commit 8d59147

Please sign in to comment.